Implement different Markdown rendering pipelines and cache Markdown

Builds on !1090 (merged).

Related to !1014 (merged).

Fixes #2054 (closed).

mentioned in merge request !1090 (merged)

Added 1 commit:

• 9c2214f2 - Remove stray conflict marker

mentioned in issue #2969 (closed)

Added 241 commits:

• 9c2214f2...d25b50fd - 240 commits from branch master
• de0acf3c - Merge branch 'master' into reference-pipeline-and-caching

@rspeicher I made pipelines actually make sense. Please have a look. I promise I will add in-line documentation once we've settled on the design. :)

Added 1 commit:

• 9301f4e0 - Make pipelines actually make sense

Added 1 commit:

• abbca615 - Make pipelines actually make sense

Added 7 commits:

• f65840bc - Fix Markdown XHTML context param
• adba37f9 - Use markdown with gfm pipeline rather than gfm method
• c1ecfb5d - Disabling caching in test environment because it was causing issues with Markdown
• c746a1de - Use faster, more appropriate pipeline for mentionable attributes
• 51ed8fd7 - Use correct var name
• aa4007a5 - Slight refactoring
• 46025ffb - Fix specs

Added 1 commit:

• 7851a292 - Use single_line Markdown pipeline for commit description

Added 114 commits:

• 7851a292...940d68cc - 113 commits from branch master
• 740feeec - Merge branch 'master' into reference-pipeline-and-caching

Added 1 commit:

• 2bbdeb91 - Reset memoized project repository when path changes

Added 1 commit:

• 28af56de - gfm is no longer

@rspeicher Ping

@DouweM Thanks, will dig in when I'm back home.

@DouweM Nice job, I think we're getting closer!

I think we should have Filters and Pipelines in separate folders and namespaces. Maybe Gitlab::Pipeline and lib/gitlab/pipeline (a la HTML::Pipeline).

I think my main concern right now is making CombinedPipeline understandable. Really good docs will help there a lot.

Also, good documentation for the various methods that utilize context or options detailing which keys are utilized will be helpful.

@rspeicher I agree with all of that! Feel free to pick it up, or I will when I get the chance.

mentioned in issue #2054 (closed)

Added 491 commits:

• 28af56de...c8074b6b - 490 commits from branch master
• f5a63011 - Merge branch 'master' into reference-pipeline-and-caching

Added 1 commit:

• e1e67d38 - Move Markdown filters and pipelines into folders.

mentioned in merge request !1845 (closed)

mentioned in issue #3507 (closed)

Added 279 commits:

• e1e67d38...09e712c0 - 278 commits from branch master
• 2955ca61 - Merge branch 'master' into reference-pipeline-and-caching

Added 48 commits:

• 2955ca61...6689224a - 47 commits from branch master
• 0dcff134 - Merge branch 'master' into reference-pipeline-and-caching

Added 188 commits:

• 0dcff134...e88fd586 - 187 commits from branch master
• d611a387 - Merge branch 'master' into reference-pipeline-and-caching

mentioned in issue #1697 (closed)

Added 1 commit:

• 611912fe - Store the demodulized reference filter name in data attribute

@DouweM Changed one minor thing that was annoying me, see above commit.

My current (admittedly pedantic) complaint is that now we've got lib/gitlab/markdown/filter/ but the files in that folder aren't in a Gitlab::Markdown::Filter module. Same with Pipelines. :) Rails would be unable to autoload these classes.

Maybe we should come up with a fun/clever/stupid name for our little pet project and move it into its own namespace, then we've just got OurDumbName::Filter::Whatever and OurDumbName::Pipeline::Whatever.

@rspeicher. Yeah, that annoys me too but I didn't want to end up with four nested namespaces. Although I guess there's not a lot of difference in readability between a Filter:: prefix and a Filter suffix.

As for dumb names, 1 quick Google search tells me that the "Banzai Pipeline" is a surf reef break in Hawaii. Banzai::Pipeline::Whatever doesn't look too bad.

Edit: Lol, I wasn't the first to make that connection: https://rubygems.org/gems/banzai

Added 1 commit:

• 13f44822 - Move CombinedPipeline methods around

Added 44 commits:

• 13f44822...f5430e48 - 42 commits from branch master
• 1a109450 - Fix RedactorFilter
• 926c3bef - Merge branch 'master' into reference-pipeline-and-caching

@DouweM Banzai's a cool name, and we're not releasing a gem, so whatevs.

Builds have been reliably green (when I'm not breaking them), so I'm leaning towards just merging this as it is and we can go back for docs and restructuring. We really need to get this shipped already and I want as much real-world testing of it on dev as possible before the RC process begins.

Whatcha think?

@rspeicher Okay by me

Title changed from [WIP] Implement different Markdown rendering pipelines and cache Markdown to Implement different Markdown rendering pipelines and cache Markdown

Status changed to merged

mentioned in commit bcd89a58

Whohooo!

mentioned in merge request !2051 (merged)

mentioned in commit 4e5897f5

mentioned in issue #4130 (closed)

mentioned in merge request !1087 (closed)