Correctly find last known blob for file deleted in MR. (!1647) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Douwe Maan requested to merge merge-request-deleted-file into master 9 years ago

Fixes #3092 (closed).

When building a new MR, @merge_request.commits.last would fail because this delegates to merge_request_diff which is still nil at that point. I fixed that, and changed some of the logic because showing deleted blob contents didn't previously work for the Compare page, and the UI would show the wrong commit sha for "View File @...".

Activity

username-removed-5302 mentioned in issue #3078 (closed) 9 years ago

mentioned in issue #3078 (closed)
username-removed-5302 @jacobvosmaer · 9 years ago

Contributor

Impressive. Glad you found the problem @DouweM
username-removed-444 @dzaporozhets · 9 years ago

Owner

👍
username-removed-444 Status changed to merged 9 years ago

Status changed to merged
Robert Speicher @rspeicher · 9 years ago

Owner

👍 💯
Stan Hu mentioned in issue #427 (closed) 9 years ago

mentioned in issue #427 (closed)
Robert Speicher @rspeicher · 9 years ago

Owner

Picked into 8-1-stable.
username-removed-444 mentioned in commit 44d35a82 9 years ago

mentioned in commit 44d35a82
username-removed-444 mentioned in commit f16bfa40 9 years ago

mentioned in commit f16bfa40

Please register or sign in to reply