Added housekeeping for git repositories
This merge request will add a housekeeping button in the project setting page which invoke the gitlab shell to run a git gc
in the project repository.
see gitlab-org/gitlab-ce#3041
Depends on gitlab-shell!23 (merged) which has been merged.
Merge request reports
Activity
Looks good. Who should review/merge it? cc @jacobvosmaer @DouweM
I am not the best for reviewing user-visible things. :) @DouweM do you feel up for reviewing this?
One thing that stands out to me is the question whether
gitlab-projects
in gitlab-shell has agc
command.https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/23 is for adding
gc
togitlab-shell
171 171 end 172 172 end 173 173 174 def housekeeping You added it on
app/views/projects/edit.html.haml
which is only available for project masters,admin_project
is only for project masters as well.I don't think housekeeping should be available to all project members, it's an administrative task not one a regular GitLab user would care about.
Edited by Douwe Maan
Added 1 commit:
- 839aae0e - Added housekeeping status and moved path check to gitlab-shell
Added 1 commit:
- d4690af8 - Use GitlabShellWorker.perform_async for housekeeping
mentioned in commit gitlab-shell@82b3a4e8
Reassigned to @DouweM
@jnijhof Please add a changelog item and change the GITLAB_SHELL_VERSION.
Reassigned to @jnijhof
Added 2246 commits:
-
d4690af8...8b39b8cd - 2244 commits from branch
gitlab-org:master
- 9b28220f - Merge gitlab.com:gitlab-org/gitlab-ce
- fe191698 - Use panel-default and .form-actions
-
d4690af8...8b39b8cd - 2244 commits from branch
Added 1 commit:
- bde76f62 - Added CHANGELOG for housekeeping and changed GITLAB_SHELL_VERSION to 2.6.10
Reassigned to @DouweM