Ability to add text and attachments to git tags in GitLab (aka Releases)

It allows user to add markdown field to each git tag. This can be used to specify release information and attach images or binary files. User can create new tag with release notes or add release notes to existing git tag

For #2701 (closed)

Add release notes to existing git tag:

go to tags page and click edit link

write markdown and save

you are redirected to tag page with release notes

go back to Tags page

Create new tag with release notes

go to new tag page

fill release description field and press save. You are redirected to tags page

TODO:

• cleanup code and UI
• tests
• CHANGELOG item

cc @JobV @patricio

Related feature requests: http://feedback.gitlab.com/forums/176466-general/suggestions/4156755-releases-with-binary-files-like-on-github

What about adding binaries? I would expect to be able to download a binary of an application on the release page.

@razer6 its markdown field. Nothing stops you from drag and drop any file to it

Right, but I would expect to be able to download it via a download button like the ZIP or TAR.GZ archive. Just from UX perspective. Maybe @creamzy or @skyruler have other thoughts?

@razer6 I don't think it makes sense to introduce new behaviour. People use drag-n-drop attachments in issues, milestones, comments. I dont think we need to invent something just for tags.

@razer6 @dzaporozhets it wouldn't hurt to make it more clear what the archives are because of this change (@creamzy might have ideas). Other than that I'm with @dzaporozhets

archives are just buttons from tags page (download source code) but yes it might be good to clarify this.

I can even remove those buttons if it brings confusion

Maybe this will be less confusing UI

This looks very cluttered to me. The question is, what's the release page for. From a developers perspective I want to get information of the versions and want to be able to get the version in source. Therefore, the SHA should be present to check it out or I can download it via zip. From an end user perspective, I want to get information and want to get the binary. These features should be supported by the GitLab UI directly. Doing it by markdown makes it more complicated, less UX and more cluttered. In my sense, downloads should be actively integrated into the release-UI because this is one of the main reasons I would go on this page.

@razer6 I really don't get why you want to make implementation more complicated. We already have file uploading via markdown field. Why not reuse it? I am not sure about UX argument because we use same logic everywhere so user familiar with it can find it easier.

This looks very cluttered to me.

Not more than any other page in GitLab. Not sure what kind of magic you expect here from me. Designers in GitLab will improve it later.

Anyway I will work on UI a bit more to see if it can be more clear

Updated UI for Tags page:

Looks great @dzaporozhets

@JobV thank you!

After a discussion with @dzaporozhets, my concerns are gone. Index page looks great 👍

Tag show page:

Looks pretty similar to what we have on index but with few extra controls.

Added 2 commits:

• 900419c4 - Improve UI for tags page
• 3c0244d3 - Retyle tag show page

What is this release note in the green background here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1752#note_2580096 ?

@axil I render it if git tag has release notes. For easier visual separation. Do you think its not necessary?

@dzaporozhets I'm not sure about the release label. Consider someone is annotating an alpha/beta version or a release candidate. Then this would add the release label although the release is a different tag.

@razer6 makes sense. I will remove release label

Title changed from WIP Release notes to WIP Ability to add text and attachments to git tags in GitLab

Added 5 commits:

• cea2afa8 - Add changelog item and remove release labels for tags list
• ed757ef6 - Rewrite remove tag test
• c1a893d9 - Fix list rendering issue when dropdown was hidden in row
• b60ad399 - Fix test
• 962b57df - Small UI improvements to new git tag page

I also cleaned up new tag page a bit

Added 2 commits:

• cb8b9c3f - Add association and validation for Release model
• 6f15356a - Add tests to release notes feature

@dzaporozhets looks great. English:

"It will be stored in the GitLab database and shown on the tags page"

@JobV thanks! I like when you help with english :)

Added 1 commit:

• 14518ba6 - Better english

@DouweM can you review code?

@dzaporozhets I will on Monday! If you want it sooner, please ask someone else :)

@DouweM thanks. Monday is ok. I will assign to you

Reassigned to @DouweM

@dzaporozhets What do you think about renaming the "Tags" tab and the "228 TABS" button on the project homepage to "Releases"? Tags are almost exclusively used for versions/releases anyway, and this makes their intent clearer to the end user.

@DouweM I think releases is a specific case of tag usage. Also it would be confusing since everywhere else it has git tag name. I want to follow git naming

Reassigned to @dzaporozhets

Added 1 commit:

• b67fdfff - Refactor release code a bit

Added 1 commit:

• b7619dad - Add missing param and title for tag

@DouweM should be good now. Want to double check?

Title changed from WIP Ability to add text and attachments to git tags in GitLab to Ability to add text and attachments to git tags in GitLab (aka Releases)

TODO: in separate merge request create API for releases (adding release note to existing tags)

@DouweM I will merge this. If you still have some comments - just ping me and I will fix in next MR

Status changed to merged

mentioned in merge request !1778 (merged)