Create milestones in the group

When you work with groups its quite often you want to create same milestone in multiple projects. This MR allows you to do so

For #3488 (closed)

Signed-off-by: Dmitriy Zaporozhets dmitriy.zaporozhets@gmail.com

Added 2 commits:

• dacf04b6 - Refactor global and group milestones logic
• 29681e66 - Fix a bug when milestone/label filter was empty for dashboard issues page

Really useful. 👍

Added 38 commits:

• 29681e66...1328e4b5 - 35 commits from branch master
• 05335a3c - Create milestones in the group
• 986695e1 - Refactor global and group milestones logic
• c79d801b - Fix a bug when milestone/label filter was empty for dashboard issues page

Screenshot:

Added 2 commits:

• 98d6d491 - Move global milestone specs
• 8a03cb87 - Lets add more tests to Milestones services

Added 1 commit:

• 8630d476 - Add header and page title to new milestone page

@JobV @sytses Does it makes sense to add same Projects selectbox if you create milestone from project page too? For example while creating milestone inside project you decided that it would be nice to create same milestone in another project of group. In this case you can just add it right there instead of canceling everything and creating milestone from group page.

Example:

One thing that is wrong on screenshots is that you can not attach files to Description field when create milestone from Group page. Because all attachments are stored in project scope you can not attach uploads to group

So I either need to remove description field from Groups page or remove Attach a file link

@dzaporozhets yes it does.

Added 1 commit:

• f16f3151 - Few changes to Group Milestone feature:

Added 1 commit:

• 78d542fc - Add milestones documentation to workflow

Added 1 commit:

• 929ab909 - Group masters should be able to create/close milestones

@JobV cool. I will create issue for this.

EDIT: #3505 (closed)

Added 1 commit:

• 32f1a719 - Fix removing avatar for group

Title changed from WIP Create milestones in the group to Create milestones in the group

I would like to see this in 8.2 to save me from creating another batch of milestones for next release

👍

Added 1 commit:

• b093f509 - Some code and doc improvements

mentioned in issue #3401 (closed)

Ok maybe stupid question.

Will I be able to edit the milestone in the group? If so, what happens if a project's milestone is edited from within the project?

Status changed to merged

mentioned in commit 0061143c

@axil no. As merge request title says you can only create milestone from group.

@dzaporozhets What these customizations for? I replaced with

  $(".datepicker").datepicker({
    dateFormat: "yy-mm-dd"
  });

and it works as before. Am I missing something?

@vsizov I probably copy-pasted code from other milestone form. And when other milestone form was created - we probably need it for work.

Yes, I already found a place where it has been copied

I will discuss it with UI team, because it's a pain and it still works when I removed it from app/assets/javascripts/due_date_select.js.es6