Publish public ssh keys under /u/<user>/keys

Publish users public ssh keys under new url

You can already get keys under user.keys, but I agree this should be better on /u/user.keys to be consistent with the user profile. @JobV What do you think?

Added 1 commit:

• 63ad36d5 - Allow to publish public ssh keys under /u//keys

Well, we won't need the switch then. Updated to reflect what @razer6 suggested. I didn't remove user.keys because it should be properly deprecated first.

I chose /u/user/keys instead of /u/user.keys because gitlab allows . as part of usernames.

Same problem exists with atom feeds: https://gitlab.com/gitlab-org/gitlab-ce/issues/3453

Title changed from [WIP] Allow to publish public ssh keys under /u//keys to Publish public ssh keys under /u//keys

Added 1 commit:

• 0c9af3ec - Allow to publish public ssh keys under /u//keys

I'm fine with it, but think @dzaporozhets should weigh in.

About profiles and consistency:

• I think user profiles should be under /username instead of /u/username. I rather move profile to different route.
• Moving route to /u/user/keys breaks consistency with GitHub. Remembering different routes is annoying. Having 2 different routes for same keys page is also not good.

I propose to:

1. reject this change (leave gitlab.com/username.keys as is)
2. move profiles under root. Like gitlab.com/username (#3620 (closed))
3. Fix #3453 (closed) by validating usernames

cc @JobV

Status changed to closed

mentioned in issue #3453 (closed)

@tback thanks