Sidekiq-cron configuration moved to gitlab.yml

When sidekiq-cron was introduced, jobs configuration where placed in schedule.yml file.

As discussed in #3928 (closed), this is not desirable. We moved it to gitlab.yml, exposing only the "cron" part of the configuration.

Cool! @rspeicher maybe this needs to be referenced in the 8.3 blog post.

@brodock a reminder that this change also needs to be in omnibus ;)

Reassigned to @dzaporozhets

@axil Sure, I will open a MR for omnibus too. Working on the EE modifications before

Added 1 commit:

• eb365788 - Sidekiq-cron configuration moved to gitlab.yml

Added 1 commit:

• 51ef4a2f - Sidekiq-cron configuration moved to gitlab.yml

I'm pretty sure config/schedule.yml only existed in master after 8.2 was released, so no blog note should be necessary.

Please correct me if I'm wrong.

@rspeicher you are right.

mentioned in issue omnibus-gitlab#992 (closed)

@rspeicher fair enough, but this introduces configuration changes, right? Shouldn't we inform people that they can now set cron jobs for some parts of GitLab in gitlab.yml?

@axil Can this be used for any arbitrary thing? I thought it was just this one specific task.

Sorry for the plural, I had in mind the other cron jobs in EE. Actually, my concern might not be to just reference this in the post, but rather have this documented somewhere.

On the other hand, we might end up adding it to the post anyway :)

@rspeicher @brodock Ping

mentioned in commit e6e338f0

Status changed to merged

I merged it. What is the next step here? Should it be cherry-picked to 8.3?

@rspeicher Please cherry pick

mentioned in merge request omnibus-gitlab!569 (merged)

FYI after this MR master gives me

→ be rake db:migrate --trace
** Invoke db:migrate (first_time)
** Invoke environment (first_time)
** Execute environment
rake aborted!
SystemStackError: stack level too deep
/Users/dzaporozhets/.rvm/gems/ruby-2.1.6/gems/rake-10.4.2/lib/rake/task.rb:183
Tasks: TOP => db:migrate => environment

mentioned in issue #4245 (closed)

Picked into 8-3-stable.

mentioned in commit b0f1453f

Mentioned in commit pfjason/gitlab-ce@683a7954

mentioned in commit 7018c5c0

mentioned in commit 91965e91

mentioned in commit 680740c5

mentioned in commit a7fff0ea

mentioned in commit 6a80267e

mentioned in commit fd4d7890

mentioned in commit d9ec830a

mentioned in commit ff347159

mentioned in commit nolith/gitlab-ce@4621fa2b

mentioned in commit nolith/gitlab-ce@0690531e