test title

References #4264 (closed)

mentioned in issue #4264 (closed)

Added 1 commit:

• 3051ff09 - Fix "undefined method `ci_commit' for nil:NilClass" in Commit model

@ayufan I've added CI data to commits list and commit details. Should we add something else?

Added 8 commits:

• 3051ff09...2c1f8e2d - 6 commits from branch master
• 979c04e6 - Add 'last_build' informations to commits list/details in API
• 531d79a1 - Fix "undefined method `ci_commit' for nil:NilClass" in Commit model

mentioned in issue #5599 (closed)

Added 1 commit:

• 69bffa16 - Update ./doc/api

I think that we should expose MergeRequests to include CI statuses.

Added 1 commit:

• 13aef532 - Modify commits API CI data, add CI data to merge_request API

Added 1 commit:

• ac5b250f - Fix error in Commit to Ci::Commit delegation

@DouweM @rspeicher Can you review?

Added 1 commit:

• fd4c2a3d - Add some fixes after review

Added 1 commit:

• 2d5b8423 - Add some fixes after review

Added 1 commit:

• be7a784d - Add some fixes after review

Title changed from [WIP] Extend commits API with CI data to Extend commits API with CI data

Added 1 commit:

• e9c950b7 - Modify commits documentation API style [ci skip]

Title changed from Extend commits API with CI data to [WIP] Extend commits API with CI data

Added 1 commit:

• 66221057 - Modify commits documentation API style [ci skip]

Added 1 commit:

• 648a2797 - Move build data to 'last_build' namespace in commit details

@DouweM I've added status and moved all build data to last_build namespace.

Title changed from [WIP] Extend commits API with CI data to Extend commits API with CI data

@tmaczukin We thought with @DouweM about the last_build, build_ and other nesting possibilities and in the end decided to put that on hold till we decide how it should look like in context of deployments that we plan to introduce in one of the upcoming releases.

We already have the status exposed, so it's good enough.

Added 1 commit:

• 56a45b09 - Modify notes about duration unit in commits and merge_requests API documentation [ci skip]

@ayufan So, to be clear - at the moment we will leave this MR and not merge it into 8.4 release. We will get back here in one of future releases, yes?

And also one question - I've moved status to last_build and now the tests are broken. If we leave last_build in the future then should we update tests and leave a notice in documentation OR should we move status back to commit?

status should be property of the commit as it was before.

Yes, exactly. Please put back [WIP].

Milestone removed

Title changed from Extend commits API with CI data to [WIP] Extend commits API with CI data

Added 1 commit:

• 01a40700 - Move status field back directly to commit data in API

Assignee removed

@tmaczukin still planning on finishing this up? :)

unmarked as a Work In Progress

changed title from [WIP] Extend commits API with CI data to test title

marked as a Work In Progress

changed title from test title to [WIP] Extend commits API with CI data

unmarked as a Work In Progress

changed title from [WIP] Extend commits API with CI data to test title

marked as a Work In Progress

changed title from test title to [WIP] Extend commits API with CI data

unmarked as a Work In Progress

changed title from [WIP] Extend commits API with CI data to test title