Allow broadcast messages to be edited (!2268) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Robert Speicher requested to merge rs-broadcasts into master 9 years ago

Closes #3046 (closed)

Activity

Robert Speicher @rspeicher · 9 years ago

Author Owner

I don't love the way the table of existing messages looks, if you have suggestions @creamzy @dzaporozhets @skyruler:
Robert Speicher Added 1 commit: 9 years ago
Added 1 commit:

10dbca66 - Update CHANGELOG
username-removed-264303 @creamzy · 9 years ago

Developer

@rspeicher I will take a look
username-removed-444 @dzaporozhets · 9 years ago

Owner

@creamzy thank you!
username-removed-264303 Added ~19492 label 9 years ago

Added ~19492 label
Robert Speicher Added 449 commits: 9 years ago
Added 449 commits:

10dbca66...b7f49aa0 - 437 commits from branch master

79361b20 - Add js-requires-input to form

1c7febc3 - Style the broadcast message form

7e24c5c4 - Move broadcast message form to a partial

6ae39c2c - Remove alert_type attribute from BroadcastMessage

12903762 - Simplify broadcast message JS

8086b2bd - Simplify BroadcastMessage factory

5a170679 - Update broadcast_message helper

df496fca - Update BroadcastMessage model

540ae3c3 - Update Broadcast Message features

00e87004 - Broadcast Messages can now be edited

c2c5e875 - Update CHANGELOG

7f99ad37 - Move BroadcastMessage#status to a helper since it's presentational
Toggle commit list
Robert Speicher Added 2 commits: 9 years ago
Added 2 commits:

c13b5acb - Update CHANGELOG

84366282 - Move BroadcastMessage#status to a helper since it's presentational
Robert Speicher @rspeicher started a thread on an old version of the diff 9 years ago
Last reply by Robert Speicher 9 years ago

Robert Speicher @rspeicher · 9 years ago

Author Owner

@DouweM This is ready code-wise if not design-wise.

Robert Speicher Added 1 commit: 9 years ago

Added 1 commit:

55d03239 - Remove (invalid) timestamp formatting

Douwe Maan Status changed to merged 9 years ago

Status changed to merged

Douwe Maan mentioned in commit 9 years ago

mentioned in commit 54734fa6

Please register or sign in to reply