Add triggers API

References #4264 (closed)

mentioned in issue #4264 (closed)

Added 1 commit:

• 30985008 - Fix ci_trigger_request factory

Added 2 commits:

• f0060743 - Add delete feature to triggers API
• 49c8bf4e - Add create feature to triggers API

Added 1 commit:

• 86756646 - Get show details feature to triggers API

@ayufan I think that this feature is ready for review

Added 1 commit:

• b0a77a22 - Update ./doc/api

I woudl prefer to use token instead of trigger_id to manage the trigger.

Added 1 commit:

• e0ec69d9 - Change 'trigger_id' to 'token' as resource ID in triggers API

@DouweM @rspeicher Can you review?

Added 1 commit:

• 34d60de3 - Add some fixes after review

Added 1 commit:

• d44653da - Add some fixes after review

Title changed from [WIP] Add triggers API to Add triggers API

Check @axil's ongoing documentation styleguide MR and make sure these API docs conform to the standard.

Added 440 commits:

• d44653da...0e344aa2 - 437 commits from branch master
• 6201a5dd - Merge branch 'master' into ci/api-triggers
• a31bd940 - Modify triggers API documentation style [ci skip]
• 58b7ce65 - Update CHANGELOG {ci skip]

@DouweM @rspeicher: Triggers entry in API documentation index prefixed, documentation style changed. CHANGELOG updated.

If there are no more comments, then ready for merging :)

LGTM.

Copying from my comment in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2264#note_3199256

Some general advice (which I forgot to document, so it's my fault):

Do not add headings for Parameters, Example of request and Example of response, add only for the main calls. Always imagine that the headings end up being referenced in doc.gitlab.com. How would you know what is referenced if your URL is api/build_variables.md#parameters ? If you have multiple times the same heading you would not know where to go.

Other than that I'll leave some inline comments.

Can you add the sentence below here?

You can read more about [triggering builds through the API](../ci/triggers/README.md).

Title changed from Add triggers API to [WIP] Add triggers API

Added 6 commits:

• 99393cde - Version 8.4.0.rc1
• d139276a - Merge branch 'master' into 8-4-stable
• 633ac134 - Modify triggers API documentation style [ci skip]
• 57a67c4f - Merge branch '8-4-stable' into ci/api-triggers
• d8359a4f - Update CHANGELOG [ci skip]
• c5b429f0 - Add mofications to triggers API documentation [ci skip]

Target branch changed from master to 8-4-stable

Title changed from [WIP] Add triggers API to Add triggers API

@axil: documentation is fixed

@rspeicher @DouweM: if there are no more comments, then ready to be merged. As we agreeded with Robert, the MR is pointing to 8-4-stable. After merge it should be picked to master.

Target branch changed from 8-4-stable to master

Added 41 commits:

• c5b429f0...4d64a32c - 39 commits from branch master
• 8eed1876 - Merge branch 'master' into ci/api-triggers
• 41eedd45 - Fix version

@DouweM: target branch switched back to master. All conflicts resolved.

Enabled an automatic merge when the build for 41eedd45 succeeds

Added 24 commits:

• 41eedd45...f981da44 - 22 commits from branch master
• af3b97cd - Merge branch 'master' into ci/api-triggers
• 7ed5bc5c - Modify entry in CHANGELOG

@DouweM I needed to resolve conflicts again and I see that my latest commit disabled the 'automatic merge', that was waiting for build to finish. Can you merge it manually? All is 'green' right now :)

@tmaczukin We still have:

This merge request contains merge conflicts

Added 175 commits:

• 7ed5bc5c...2f2aada3 - 173 commits from branch master
• 768721dc - Merge branch 'master' into ci/api-triggers
• 96aeaeaf - Update CHANGELOG

@ayufan Builds MR was merged first - that generated new conflicts. Resolved. I've also removed duplicate from CHANGELOG (variables features for API was entered two times).

Ready to merge - again :)

Status changed to merged

mentioned in commit 948bb655

Picked into 8-4-stable.

mentioned in commit c7ee7eea

mentioned in issue #4218 (closed)

mentioned in issue #10852 (closed)

mentioned in issue #10421 (moved)

Mentioned in commit maxraab/gitlab-ce@c7ee7eea