Remove Block Button from Abuse Reports page if User is Already Blocked

Looks good to me.

/cc: @rspeicher

Reassigned to @rspeicher

Would it be better to just not show anything in this case? Also how often does this happen?

Also how often does this happen?

Enough for Kelvin to make a MR.

Would it be better to just not show anything in this case?

What conveys more meaning? I think this is better than not showing the button.

I think it looks weird with potentially different button alignments:

@kelvinmutuma Do you generally block people from the abuse report page, and then remove them and the report?

@rspeicher This is useful when you explicity do not want to delete the user. Let's say they are just a troll user on just one repo but they have repos they have been contributing to, they have contributed genuine issues in the past and they own maybe a few groups etc. If you delete the user all this will go with them and that is where block is important. Or they have been giving meaningful input before and you need to confirm with someone before deleting the user so you apply a quick block action to bar the user temporarily.

When someone reports this user, and you click block from the abuse_reports page, absolutely nothing changes on the UI so you are not sure if anything has happened. This can be resolved with a flash notice.

However when you reload the page it also does not make any sense to say block again when the user is already blocked. You could say we include a flash notice that says "User is already blocked" when the user clicks the button but at a glance someone should be able to see Aaah, this user is already blocked so there needs to be no action for the moment unless I get confirmation that I can remove this user.

@kelvinmutuma Great explanation, thanks!

Status changed to merged

mentioned in commit 00a68c3c

mentioned in issue #4667 (closed)

Admin message

Admin message

Remove Block Button from Abuse Reports page if User is Already Blocked

Merge request reports

Activity