Update Ruby version to 2.2.4 (latest previous stable) and update docs

Tests and issues added to https://github.com/gitlabhq/gitlabhq/issues/8696 were all fine after the upgrade.

Main issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/3340

@DouweM the CI runner seems to be using Ruby 2.1:

ruby 2.1.8p440 (2015-12-16 revision 53160) [x86_64-linux]```

(When inspecting the build currently running)

Do we have to update the CI project also?

Reassigned to @DouweM

@ayufan How can we get Ruby 2.2.4 on CI?

mentioned in issue #12507 (closed)

1. In case of Docker (public shared runners, which also build this project) I would go to: .gitlab-ci.yml and add:

image: ruby:2.2

2. In case of specific runners assigned to this project I would ask in #operations to maybe install ruby runtime and make it switchable with something like rvm.

/cc @DouweM

@ayufan I will try 1 first, thanks!

Added 1 commit:

• ba07a4c9 - update gitlab ci docker image version

@jameslopez It only solves half of the runners :)

Added ruby label

We need to solve the second half with help of #operations

@ayufan ah I see, will discuss that with #operations then. Thanks!

Reassigned to @jameslopez

Proposed solution for CI difficulties: standardize on Docker https://gitlab.com/gitlab-com/operations/issues/47 .

We changed all the runners to Docker but now we are seeing some MySQL/Postgres problems in CE's gitlab-ci.yml https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2558

@jameslopez all builds for this project run on Docker now. Hope that helps.

Added 179 commits:

• ba07a4c9...0e51ca7c - 178 commits from branch gitlab-org:master
• 3d81f1da - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into update-ruby-2.2.4

@jacobvosmaer awesome! thanks again 👍

@jameslopez you missed two sections in docs :)

Make sure to change the note in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/installation.md#2-ruby and also in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/install/requirements.md#ruby-versions

Thanks @axil - I wasn't sure and I left those and L70 of the main README: https://gitlab.com/gitlab-org/gitlab-ce/edit/master/README.md

So just had to confirm, are we changing the minimum required version to 2.2 now so we remove 2.1 from the list?

I'm still making sure this works fine until I remove the WIP anyway :)

Added 72 commits:

• 3d81f1da...07ee8393 - 71 commits from branch gitlab-org:master
• 719b73b8 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into update-ruby-2.2.4

Added 1 commit:

• ee209cc9 - fix rubocop new 2.2 syntax issues

Added 1 commit:

• 870e38ea - updated docs to reflect version update [ci skip]

@DouweM feel free to review this. I assumed we are dropping support for 2.1 now... Last build is green: https://gitlab.com/jameslopez/gitlab-ce/commit/ee209cc936d9242af2b2d8d45ecb64adc55e3a51/builds

Reassigned to @DouweM

Title changed from WIP: Update Ruby version to 2.2.4 (latest previous stable) and update docs to Update Ruby version to 2.2.4 (latest previous stable) and update docs

@dzaporozhets Do you think it's OK to drop Ruby 2.1 support?

@DouweM I think we should keep 2.1 compatibility for now. Ruby 2.2 is only 1 year old.

@dzaporozhets @DouweM thanks! keeping compatibility is fine. I would say a downside would be that the team and the CI runners will run on 2.2, so new issues exclusively on 2.1 would be more difficult to spot...

@ayufan Will the all-encompassing GitLab Deploy allow building both on 2.1 and 2.2? ;)

@jameslopez Please update the docs to say we still support 2.1!

Reassigned to @jameslopez

@DouweM We don't need GitLab Deploy for that. This is already possible.

We can add extra jobs to .gitlab-ci.yml that will test against different image:

rspec:ruby21:
  image: ruby:2.1
  script: bundle exec...
  only:
  - master

This will use ruby:2.1 for that job instead of ruby:2.2 specified globally.

Added 1 commit:

• 1b84de57 - updated docs to reflect min requirement of 2.1 [ci skip]

Title changed from Update Ruby version to 2.2.4 (latest previous stable) and update docs to WIP: Update Ruby version to 2.2.4 (latest previous stable) and update docs

@ayufan Thanks! Trying that now.. Would this introduce any significant overhead to the servers or would it be just fine?

@DouweM am I safe to remove things like rubocop, brakeman, flog, flay and teaspoon for 2.1? It looks to me that they should be covered with the run in 2.2.

@jameslopez It will increase the load, but this will be resolved by scaling up our infrastracture. We should run ruby:2.1 tests on master only I think.

@ayufan thanks! that makes sense 👍

Added 1 commit:

• b8ed5789 - update gitlab ci settings to include ruby 2.1 images

Added 87 commits:

• b8ed5789...a93f7099 - 86 commits from branch gitlab-org:master
• 683770f3 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into update-ruby-2.2.4

Added 2 commits:

• e862af95 - merge spec and spinach jobs
• 47e0d6b1 - updated README to include Ruby 2.1

Why do we need assets:precompile?

@ayufan Copied from spec:feature, which runs as part of rake spec - I assume is something to do with capybara @DouweM ?

No idea :) But since it's already there for spec:feature, let's not worry about it right now.

Title changed from WIP: Update Ruby version to 2.2.4 (latest previous stable) and update docs to Update Ruby version to 2.2.4 (latest previous stable) and update docs

Reassigned to @DouweM

ready to be reviewed again :)

Enabled an automatic merge when the build for jameslopez/gitlab-ce@47e0d6b16242cef440244e7d31f1310dea42f5ef succeeds

Status changed to merged

mentioned in commit f025f80d

This MR broke the build https://gitlab.com/gitlab-org/gitlab-ce/commit/f025f80d5c6f84639b058533ee00c72a7b65918f/builds

The issue seems to be that rubocop complains about syntax in ruby 2.2 but the fix actually breaks GitLab for ruby 2.1.

mentioned in issue #12801 (closed)

mentioned in issue omnibus-gitlab#1087 (closed)

mentioned in issue #13252 (closed)

mentioned in issue #14286 (moved)