Lazy Git blobs
To prevent madness like loading a 100MB file into Ruby's memory just to decide whether it is binary or text.
Merge request reports
Activity
mentioned in merge request !2451 (merged)
Added 1 commit:
- 29d37602 - Update gitlab_git (lazy-blob branch)
Added 1 commit:
- b1a7cb57 - Update gitlab_git@lazy-blob again
Unless we also merge https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2451 , this MR will break images > 1KB in the tree browser.
Seeing a string of failures that look like:
6) Comments On a merge request diff when adding a note the note form should be removed when canceled Failure/Error: Unable to find matching line from backtrace ActionView::Template::Error: Revspec '645f6c4c82fd3f5e06f67134450a570b795e55a6' not found.
Added 1 commit:
- b4e6ee7a - Update development version of gitlab_git
Now something about CI secret variables.
========= 1) Ci::Variable value fails to decrypt if iv is incorrect Failure/Error: expect { subject.value }. expected OpenSSL::Cipher::CipherError with "bad decrypt" but nothing was raised # ./spec/models/ci/variable_spec.rb:42:in `block (3 levels) in <top (required)>' Progress: |================output error : unknown encoding ASCII-8BIT output error : unknown encoding ASCII-8BIT =======================================/builds/gitlab-org/gitlab-ce/spec/models/repository_spec.rb:109: warning: already initialized constant TestBlob /builds/gitlab-org/gitlab-ce/spec/models/repository_spec.rb:109: warning: previous definition of TestBlob was here =============|
Reassigned to @DouweM
This is ready for review but we need to take care when merging to first:
- release a new gitlab_git with gitlab_git!64 (merged), and
- update the Gemfile in this MR to use the then latest version of gitlab_git.
mentioned in merge request gitlab_git!64 (merged)
@jacobvosmaer LGTM! (Except for the stylistic complaint, that is)
Edited by Douwe MaanReassigned to @jacobvosmaer
Added 1 commit:
- c76e6b98 - Move load command into _text partial
Added 1 commit:
- 0a4db90d - Use begin/end instead of defined?
Added 20 commits:
-
0a4db90d...6cffcb05 - 18 commits from branch
master
- e08aa3df - Use gitlab_git 8.0.0
- d3affe8b - Merge remote-tracking branch 'origin/master' into lazy-blobs
-
0a4db90d...6cffcb05 - 18 commits from branch
mentioned in commit 53726415