Bugfix/jschatz1/02 16 16 (!2845) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Closed Jacob Schatz requested to merge bugfix/jschatz1/02-16-16 into master 9 years ago

Add site wide scrollbar styles.

By adding scrollbar styles the double scrollbar won't show.
Fix will fix the scrollbar issue with "always" show scrollbars as well.

@creamzy @skyruler can you approve the style?

Activity

username-removed-128633 @rymai started a thread on the diff 9 years ago

db/schema.rb

    t.integer  "layout",                      default: 0
    t.boolean  "hide_project_limit",          default: false
    t.string   "unlock_token"
    t.text     "note"

Jacob Schatz Status changed to closed 9 years ago

Status changed to closed

username-removed-264303 @creamzy · 9 years ago

Developer

@jschatz1 not sure, if I understand the style. Is the black scroll custom?

If it is, please change it to #f8f8f8 , or some other grey, as we have different themes, and some themes are too light to look good with a black scrollbar. If it's not custom and depends on the OS, I have nothing to say, but to agree.

Anyway if my answer does not satisfy you, please give me more visual details

username-removed-363446 @TR4Android · 9 years ago

@jschatz1 Maybe you could reuse the custom scrollbar used for the left side navigation? It seems to work rather well (overlays the content and disappears when not needed) and that would also improve style consistency.

Please register or sign in to reply