WIP: Read {ISSUE,MERGE_REQUESTS}_TEMPLATE from repository head (!2864) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Closed Kamil Trzcińśki requested to merge read-template-from-repository into master 9 years ago

Put the ISSUE_TEMPLATE or MERGE_REQUESTS_TEMPLATE and the description field of issues or merge requests will be filled with that content.

Activity

Kamil Trzcińśki Title changed from Read {ISSUE,MERGE_REQUESTS}_TEMPLATE from repository head to WIP: Read {ISSUE,MERGE_REQUESTS}_TEMPLATE from repository head 9 years ago

Title changed from Read {ISSUE,MERGE_REQUESTS}_TEMPLATE from repository head to WIP: Read {ISSUE,MERGE_REQUESTS}_TEMPLATE from repository head
Robert Speicher @rspeicher · 9 years ago

Owner
We should support an optional .md extension

It should be MERGE_REQUEST_TEMPLATE (singular)

What happens if they've already set a template in the Project settings?
Kamil Trzcińśki @ayufan · 9 years ago

Author Maintainer

If used with EE: the Project settings will take precedence.
Douwe Maan @DouweM · 9 years ago

Maintainer
Some more ideas:

Support the optional .github folder, as well as .gitlab (because why not)

Support PULL_REQUEST_TEMPLATE

Take a look at http://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/repository.rb#L325 for inspiration. I think these methods are nicer on repository than project
Kamil Trzcińśki @ayufan · 9 years ago

Author Maintainer

@DouweM Good idea :)
Sid Sijbrandij @sytses · 9 years ago

Owner

@ayufan thanks, I agree with the comments of @rspeicher and @DouweM
Robert Speicher mentioned in issue #9088 (closed) 9 years ago

mentioned in issue #9088 (closed)
username-removed-207411 @muhmuhten · 9 years ago

In the vein of alternative locations: it seems like it would be feasible to source these files from a separate metadata branch. This would be preferable in cases where procedure is not necessarily linked to the state of the primary branch.

A particular case I had in mind: keeping issue templates together with code seems very questionable when using git to generate release tarballs.
Robert Speicher @rspeicher · 9 years ago

Owner

A particular case I had in mind: keeping issue templates together with code seems very questionable when using git to generate release tarballs.

I think this is a good point. Maybe not something we support in the first iteration, though.
Kamil Trzcińśki Added 1 commit: 9 years ago
Added 1 commit:

48daab5f - Use repository and redis cache
Kamil Trzcińśki @ayufan · 9 years ago

Author Maintainer

@rspeicher @DouweM Second go :)
Kamil Trzcińśki Added 1 commit: 9 years ago
Added 1 commit:

0ef796d6 - Fix regexp
Douwe Maan @DouweM started a thread on the diff 9 years ago

app/controllers/projects/issues_controller.rb

50	50	)
51	51
52	52	@issue = @noteable = @project.issues.new(issue_params)
	53
	54	@issue.description = @project.repository.issues_template
Douwe Maan @DouweM · 9 years ago Maintainer Method name is wrong, and the method would return the blob, not it's text :)

Robert Speicher @rspeicher started a thread on the diff 9 years ago

app/models/repository.rb

    end
  end
  def issue_template
    cache.fetch(:issue_template) do

Sid Sijbrandij Milestone changed to 8.6 9 years ago

Milestone changed to 8.6

Sid Sijbrandij Added ~131895 label 9 years ago

Added ~131895 label

username-removed-128633 Milestone changed to 8.7 8 years ago

Milestone changed to 8.7

Douwe Maan Milestone changed to 8.8 8 years ago

Milestone changed to 8.8

Douwe Maan Milestone removed 8 years ago

Milestone removed

username-removed-152826 @ben.boeckel · 8 years ago

Contributor

Obsoleted by !4981 (merged)?

Grzegorz Bizon Status changed to closed 8 years ago

Status changed to closed

Grzegorz Bizon @grzesiek · 8 years ago

Maintainer

Let's close it in favor of !4981 (merged), /cc @felipe_artur.

Please register or sign in to reply