An error occurred while fetching the assigned milestone of the selected merge_request.
Profile settings
Updates the UI for all profile settings pages
Closes #13853 (closed)
Merge request reports
Activity
Reassigned to @jschatz1
@iamphill next time please split it on multiple merge requests. Its easier to review then. cc @jschatz1
Edited by username-removed-444@iamphill Next time split it. Too much work to split it now.
@dzaporozhets @jschatz1 yeah i'm sorry guys
🙈 think I got a bit carried away...1 1 class Profiles::AccountsController < Profiles::ApplicationController 2 2 def show 3 unless current_user.otp_secret 4 current_user.otp_secret = User.generate_otp_secret(32) 5 end 6 7 unless current_user.otp_grace_period_started_at && two_factor_grace_period 8 current_user.otp_grace_period_started_at = Time.current 9 end 10 11 # current_user.save! if current_user.changed? 12 @jschatz1 now when I see how huge changes are I put veto on merging it in one request. Its 800 lines added and 600 lines removed. Nobody would be able to efficiently review it
@iamphill You are going to have to split this into multiple MR's.
Added 75 commits:
- 54ce9568...7d41e4dc - 61 commits from branch
master
- 38bcbdfb - Profile settings
- b6eda35b - Account settings
- 2d86e8f0 - Saves current_user on account page
- 15a79b89 - Applications tab on profile settings
- 7748df5a - Emails settings
- cee157bd - Password settings page
- 1aa2ba48 - Notifications settings UI
- caa3dc4e - SSH keys settings
- 5b193199 - Updated tests
- 86e0f10d - Fixed ssh key tests
- 08a1de47 - Preferences view
- fca42c76 - audit log UI update
- 1b9f321e - Updated markup
- 85facbd5 - Fixed failing tests
Toggle commit list- 54ce9568...7d41e4dc - 61 commits from branch
Please register or sign in to reply