Skip to content

Disable turbolink on links pointing out to CI services

username-removed-53816 requested to merge byo/gitlab-ce:disable-turbolink-on-ci-links into master

What does this MR do?

This MR adds 'data-no-turbolink' attribute into all links pointing to CI services.

Are there points in the code the reviewer needs to double check?

No

Why was this MR needed?

In rare cases where gitlab and CI service is installed on the same host, turbolink will be used for links between those two. This may result in corrupted css and javascript.

This change is harmless for installations that do not share the domain name for GitLab and CI system - in such case, all links modified are already pointing out outside of the domain so turbolink won't handle them.

What are the relevant issue numbers / Feature requests?

I consider this a small fix, no issue has been added.

Merge request reports