Updated UI for new merge request

Closes #2540 (closed)

Added 1 commit:

• a86872d3 - Fixed failing tests

Added 661 commits:

• a86872d3...98fbde54 - 658 commits from branch master
• 7c0768a3 - Updated UI for new merge request
• c7af3ce7 - Fixed failing tests
• 864f5cc0 - Use new dropdowns for MR compare

Added 1 commit:

• fa9bcb3b - Checkmarks in dropdowns for already selected values

Added 1 commit:

• f5148d4b - Filters by text on element

Added 1 commit:

• 076fe277 - Fixed target project update

Added 1 commit:

• c289e712 - Removed un-used get request

Unmarked this merge request as a Work In Progress

Milestone changed to 8.7

Added 371 commits:

• c289e712...f76bfed9 - 362 commits from branch master
• c5c05f6a - Updated UI for new merge request
• 7fe19046 - Fixed failing tests
• b3100589 - Use new dropdowns for MR compare
• 850fa65e - Checkmarks in dropdowns for already selected values
• beab104d - Filters by text on element
• 1af1b6c8 - Fixed target project update
• fe811a7c - Removed un-used get request
• 8cdb5058 - Fixed spacing in MR footer
• 017ed4ae - Fixed builds

Added 1 commit:

• 39ecce05 - Build fix

Added 1 commit:

• 1ca627f7 - Fixed tests

Reassigned to @jschatz1

I guess we could've made this a jquery plugin so we wouldn't have to loop. Oh wait you did. Why are we calling each on our own.

As per here https://learn.jquery.com/plugins/basic-plugin-creation/

We need it because each dropdown has a different field name and each dropdown does a different action when clicked

@iamphill right so you are assuming that no two drop downs will be the same. But even if they are not you could still add this here and not use it ever right?. But if we are releasing this to the open source community we might want to think about what other people might do. Fine for now but food for thought.

But confused because this is exactly how we are doing the dropdowns for the filtering & the sidebar. Nothing new or different

Obviously it works and it's great. There's nothing to change now. But if we are making a jquery plugin for the world to see and use then maybe it should be in the style of a typical jquery plugin. That's all I am saying. Maybe not. Maybe our use case is typical enough.

Again leave it for this merge request. But if we are doing things with bower and turning bower packages into gems then maybe this becomes a bower package and if so it should be ready for the big time.

Great work @iamphill

I get what you mean

Some of these places you don't need double quotes.

Bad habit I need to break!

Thanks for fixing it!