Skip to content

Do not default LDAP active_directory flag to true

Drew Blessing requested to merge dblessing/gitlab-ce:dont_default_active_dir_to_true into master

We are essentially dooming all LDAP users to have active_directory set to true, when not explicitly set to false. This seems like a bad idea. This default will not work with pending LDAP group sync changes in EE (gitlab-org/gitlab-ee!229) so we have to change this.

I think this is a pretty safe change to make. I believe most users have active_directory set to true, when they really are using AD. Don't merge this until @jacobvosmaer gets to weigh in.

Merge request reports