Skip to content

Disabled SelectorFormat rule for SCSS Lint in order to get the Rake task passing sooner.

username-removed-386624 requested to merge connorshea/gitlab-ce:css-selector-format into master

SelectorFormat enforces that CSS classes and IDs use lowercase hyphenated style, like-this, but a not-insignificant amount of selectors in the codebase are like_this.

Fixing the selectors that break this rule would require changing HTML as well, and potentially break JavaScript hooks, among other things. So I decided to disable this rule for the time being, hopefully making it easier to fix all the remaining warnings SCSS Lint is giving by removing the most problematic rule.

Discussed in #14299 (closed).

cc: @jschatz1

Merge request reports