Skip to content
Snippets Groups Projects

Fix milestone removal problem when editing issues

Merged Fix milestone removal problem when editing issues
issue_1752 into master
Merged Felipe Artur requested to merge issue_1752 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Speicher
  • Robert Speicher Reassigned to @felipe_artur

    Reassigned to @felipe_artur

  • Robert Speicher
    Robert Speicher @rspeicher started a thread on the diff
    • spec/helpers/issues_helper_spec.rb
    148 148 expect(awards_sort(data).keys).to eq(["thumbsup", "thumbsdown", "lifter"])
    149 149 end
    150 150 end
    151
    152 describe "#milestone options" do
    153 let!(:closed_milestone) { create :closed_milestone, title: "closed milestone", project: project }
    154 let!(:milestone1) { create :milestone, title: "open milestone 1", project: project }
    155 let!(:milestone2) { create :milestone, title: "open milestone 2", project: project }
    156
    157 before { issue.update_attributes(milestone_id: closed_milestone.id) }
    158
    159 it "gets closed milestone from current issue" do
    160 options = milestone_options(issue)
    • Robert Speicher
      Robert Speicher @rspeicher ·
      Owner

      Move setup (let, before) inline, follow four-phase test.

    • Felipe Artur
      Felipe Artur @felipe_artur ·
      Author Maintainer

      This is not a setup. This is the subject.

    • Robert Speicher
      Robert Speicher @rspeicher ·
      Owner

      Except now what you've added as subject is actually the "exercise" phase. Do this:

      describe "milestone_options" do
  it "gets closed milestone from current issue" do
    closed = create(:closed_milestone, project: project)
    milestone1 = create(:milestone, project: project)
    milestone2 = create(:milestone, project: project)
    issue.update_attributes(milestone_id: closed_milestone.id)

    options = milestone_options(issue)

    expect(options).to have_selector('option[selected]', text: closed_milestone.title)
    expect(options).to have_selector('option', text: milestone1.title)
    expect(options).to have_selector('option', text: milestone2.title)
  end
end
  • Felipe Artur Added 1 commit:

    Added 1 commit:

    • dbcec158 - Code improvements
  • Felipe Artur Reassigned to @rspeicher

    Reassigned to @rspeicher

  • Robert Speicher
    Robert Speicher @rspeicher ·
    Owner

    And please try to write a commit message more useful than "Code improvements".

  • Felipe Artur Added 1 commit:

    Added 1 commit:

  • Felipe Artur
    Felipe Artur @felipe_artur ·
    Author Maintainer

    Done

  • Robert Speicher mentioned in commit 0913204f

    mentioned in commit 0913204f

  • Robert Speicher Status changed to merged

    Status changed to merged

  • Robert Speicher Milestone changed to 8.7

    Milestone changed to 8.7

    • Please register or sign in to reply