Skip to content

Add notes notifications to services

This merge request builds on top of a few other merge requests:

The purpose of this merge request is to add service notification support when a user comments on one of the following:

  • commits
  • issues
  • merge requests
  • code snippets

Currently HipChat and Slack are only supported. The admin can select which events to toggle on or off.

Questions

All note events are bundled under the note event type. Is this okay, or does it make more sense to have individual events and/or change the object_type attribute in the hook data?

Also, does it look better to link the entire merge request #X as opposed to just #X? I like the former.

Before

Screen Shot 2015-03-01 at 3.05.56 PM

After

Screen Shot 2015-03-06 at 6.24.40 AM

Slack

Screen Shot 2015-03-01 at 2.59.00 PM

HipChat

Screen Shot 2015-03-01 at 2.59.19 PM

Merge request reports