Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag for better performance

This was originally opened at !1757 (closed) by @pcarranza but I changed it to use Rugged instead of gitlab_git, following @DouweM's request.

Once this is merged, https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/26 will be mergeable too.

mentioned in issue gitlab_git#19 (closed)

mentioned in merge request !1757 (closed)

@rymai Please fix the merge conflict

Reassigned to @rymai

Added 130 commits:

• 746b6fd3...6d899f46 - 129 commits from branch master
• bd3d5815 - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…

Added 1 commit:

• 1218c808 - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…

@DouweM Done, thanks!

Reassigned to @DouweM

Milestone changed to 8.7

Added repository label

@rymai We should do similar to CreateBranchService and Repository#add_branch, and let GitHooksService and GitTagPushService handle all the post-push processing. Not high priority.

Reassigned to @rymai

@DouweM Right, there's some duplication indeed. I'll get to this one later. Thanks for the heads-up!

Milestone changed to 8.8

Added 516 commits:

• 1218c808...be85fde6 - 514 commits from branch master
• eac94041 - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• 2cfc403d - Use a similar approach to branch creation for tag creation

Added 4 commits:

• 2cfc403d...81cb636e - 2 commits from branch master
• 079000ee - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• 19916cc4 - Use a similar approach to branch creation for tag creation

Added 4 commits:

• 19916cc4...c295f0d2 - 2 commits from branch master
• 3154de99 - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• 49fd104a - Use a similar approach to branch creation for tag creation

Added 51 commits:

• 49fd104a...f127edd0 - 49 commits from branch master
• 1768855b - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• 7b9becae - Use a similar approach to branch creation for tag creation

@DouweM Refactored, thanks!

Reassigned to @DouweM

Added 210 commits:

• 7b9becae...351df5a9 - 208 commits from branch master
• 902e099b - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• 4e9b9749 - Use a similar approach to branch creation for tag creation

mentioned in issue #3329 (closed)

Added 8 commits:

• 4e9b9749...a4df822b - 6 commits from branch master
• 7e34f719 - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• d17f68cb - Use a similar approach to branch creation for tag creation

@DouweM Rebased, tests pass etc.! ;)

@rymai I was already viewing this just as you commented :)

@rymai Fix that error message, and you can merge instead of waiting another 14 days for me to get to reviewing this :P

Reassigned to @rymai

Added 16 commits:

• d17f68cb...72e4bd5f - 14 commits from branch master
• 44f89eaf - Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag f…
• 209f2f1e - Use a similar approach to branch creation for tag creation

Fix that error message, and you can merge instead of waiting another 14 days for me to get to reviewing this :P

Ahaha thanks!

Enabled an automatic merge when the build for 209f2f1e succeeds

mentioned in commit 1a9d5059

Status changed to merged

mentioned in merge request gitlab_git!98 (merged)

mentioned in commit gitlab_git@48fc4a1d