Skip to content

WIP: Prevent stale data in Group `owners` method

Drew Blessing requested to merge dblessing/gitlab-ce:17764-fix-last-owner into master

What does this MR do?

Fix potential for stale data in the Group last_owner? method.

Are there points in the code the reviewer needs to double check?

Negative. Should be safe

Why was this MR needed?

Customers were reporting that LDAP group sync would occasionally remove the last owner of a group. This didn't seem right (we have tests for this) so I dug in to see what was going on. I can see how this memoization would lead to stale data and thus, the bug in LDAP group sync.

Fixes #17764 (closed)

Merge request reports