WIP: Prevent stale data in Group `owners` method (!4266) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Closed Drew Blessing requested to merge dblessing/gitlab-ce:17764-fix-last-owner into master 8 years ago

What does this MR do?

Fix potential for stale data in the Group last_owner? method.

Are there points in the code the reviewer needs to double check?

Negative. Should be safe

Why was this MR needed?

Customers were reporting that LDAP group sync would occasionally remove the last owner of a group. This didn't seem right (we have tests for this) so I dug in to see what was going on. I can see how this memoization would lead to stale data and thus, the bug in LDAP group sync.

Fixes #17764 (closed)

Activity

Drew Blessing Marked this merge request as a Work In Progress 8 years ago

Marked this merge request as a Work In Progress
Drew Blessing @dblessing · 8 years ago

Author Maintainer

owners is not longer a method, but an AR association. I moved the fix to group sync code in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/529.
Drew Blessing Status changed to closed 8 years ago

Status changed to closed

Please register or sign in to reply