Skip to content

Replace `link_to_gfm` with `link_to` in merge request and issue titles.

username-removed-386624 requested to merge link-to-in-issues-index into master

What does this MR do?

This removed GitLab Markdown Formatting from issue titles due to issues and confusion it caused as well as performance reasons.

On the issue/MR page itself, the formatting is preserved. This only effects index pages. See:

Screen_Shot_2016-05-24_at_3.31.17_PM

I think the trade-off here is worth it, otherwise we'd just be playing wack-a-mole.

Are there points in the code the reviewer needs to double check?

I don't think so.

Why was this MR needed?

Previously if an issue had an emoji for its name it would be unclickable. Similarly, links were rendered inline if the title was something like “Fixes a bug with https://google.com”. This confused a number of users, so it’s removed.

This is also ever so slightly more performant :)

What are the relevant issue numbers?

This fixes #17614 (closed) and #17230 (closed).

Screenshots (if relevant)

Before:

Screen_Shot_2016-05-24_at_3.19.52_PM

After:

Screen_Shot_2016-05-24_at_3.20.13_PM

Before:

Screen_Shot_2016-05-24_at_3.20.48_PM

After:

Screen_Shot_2016-05-24_at_3.20.42_PM

cc: @rspeicher @jschatz1

Merge request reports