Skip to content
Snippets Groups Projects

Fix issue being ordered twice and callback when moving between states

Merged Felipe Artur requested to merge issue_15588 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @felipe_artur Some comments for you.

  • Shouldn't this have tests so it doesn't happen again?

  • Felipe Artur Added 1 commit:

    Added 1 commit:

    • 69a37dd4 - Add specs and improve coffescript sortable binding function
  • @jschatz1 Made your changes request
    Added ruby spec to ensure returning values are right

    Answering your question: We are not binding anything to parent, sortable binds an event for source container and target container,
    so we should update sorting only in same container.

    This patch also fixes error message when moving between "closed and open" states.

  • Reassigned to @jschatz1

  • Felipe Artur Added 1 commit:

    Added 1 commit:

    • 72c412d2 - Add specs and improve coffescript sortable binding function
  • Felipe Artur Added 1 commit:

    Added 1 commit:

    • aee371d3 - Add specs and improve coffescript sortable binding function
  • @jschatz1 Please review again.

  • @fatihacet can you review?

  • Reassigned to @fatihacet

  • Felipe Artur Added 2070 commits:

    Added 2070 commits:

    • aee371d3...699badab - 2068 commits from branch master
    • 5440be5d - Fix issue being ordered twice and callback when moving between states
    • b909340e - Add specs and improve coffescript sortable binding function
  • Found out that sorting and updating in Merge request were broken as well.
    Found a better way to do this without need to change backend.

  • Reassigned to @fatihacet

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading