Skip to content

Ensure only IDs ending in .git perform git actions

username-removed-443319 requested to merge fix-git-http-routing into master

What does this MR do?

Rails's routing is pretty strange. Previously, GET /namespace/project/info/refs would go to the Git HTTP controller (if the redirect for that case was taken out).

Are there points in the code the reviewer needs to double check?

The specs fail if the redirect is moved to above the Git HTTP routes, removed altogether, or the Git HTTP constraints are changed. But there might still be missing cases.

Why was this MR needed?

The master build and HTTP cloning were both broken.

What are the relevant issue numbers?

Closes #18376 (closed).

Screenshots (if relevant)

Nope.

Does this MR meet the acceptance criteria?

Merge request reports