Skip to content

WIP: Branch UX

username-removed-386624 requested to merge connorshea/gitlab-ce:branch-ux into master

What does this MR do?

Improves the Branch Management UX by:

  • Adding a loading indicator to the "Remove branch" button
  • Replacing the branch buttons with "Deleted" once a branch is deleted
  • Removing the visual noise of the most recent commit information

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

The branches page needed some love, as discussed in #18201 (moved). This makes some basic improvements to it.

What are the relevant issue numbers?

#18201 (moved)

Screenshots (if relevant)

Known Issues

  • Deleting multiple branches causes the AJAX responses to freeze up (or at least appear to), this is presumably a problem with the way I've implemented the ajax handlers.
  • Clicking the Remove branch button repeatedly causes multiple loading indicators to be displayed inside the button.
  • The Bootstrap tooltip should probably disappear after clicking the button, right now it hovers there forever if you don't move the mouse away from the button. This can possibly be fixed by removing the title attribute?

Merge request reports