Skip to content

Fix migration helper race conditions

yorickpeterse-staging requested to merge fix-migration-helper-race-conditions into master

What does this MR do?

This MR fixes two problems with the migration helpers:

  1. An error in change_column_null would not drop the previously created column
  2. update_column_in_batches would rely on the number of rows in a table to determine how many to update. This meant that newly inserted rows (after the COUNT) would not be taken into account.

This MR also removes an outdated comment for update_column_in_batches.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

See above.

What are the relevant issue numbers?

Fixes #18483 (closed)

Does this MR meet the acceptance criteria?

Merge request reports