Fix note polling when a window has been hidden (!4635) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged Robert Speicher requested to merge rs-fix-note-polling into master 8 years ago

refresh was called, refreshing was set to true, but then because document.hidden was true, getContent was never called, and refreshing never got reset to false, which stopped polling entirely until refresh.

Activity

Robert Speicher Reassigned to @jschatz1 8 years ago

Reassigned to @jschatz1
username-removed-502136 @fatihacet 8 years ago

Contributor

LGTM. Nice catch @rspeicher
Jacob Schatz Status changed to merged 8 years ago

Status changed to merged
Jacob Schatz mentioned in commit 27f75cf4 8 years ago

mentioned in commit 27f75cf4
username-removed-502136 Added ~149423 label 8 years ago

Added ~149423 label
Robert Speicher @rspeicher 8 years ago

Author Owner

Already in 8-9-stable for RC4.
Robert Speicher Removed ~149423 label 8 years ago

Removed ~149423 label

Please register or sign in to reply