Fix the logo in header not being an anchor link.

What does this MR do?

Adds an actual link to the Tanuki in the header instead of a Turbolinks.visit().

Are there points in the code the reviewer needs to double check?

Do we care that this reverts the Safari issue fixed in !2690 (closed)? I feel bad, but it's hacky and there's not a great way to fix it here.

Why was this MR needed?

You couldn't open the home page in a new tab before, it was very annoying.

What are the relevant issue numbers?

Fixes #18604 (closed)

cc: @rspeicher

mentioned in issue #18604 (closed)

@annabeldunstone @connorshea this is a global problem. Let's fix the global problem instead of this one tiny issue.

Reassigned to @jschatz1

@jschatz1 simple, don't use Turbolinks.visit for links like this :)

This sparked a chat-stravaganza: https://gitlab.slack.com/archives/frontend/p1465944527000472

@rspeicher chataganza? @connorshea define "links like this"...

@jschatz1 any link which doesn't absolutely necessitate using Turbolinks.visit (I'm not entirely sure what situations this would ever be necessary)

@connorshea sounds vague.

I'm with @connorshea on this. The logo should be a link and not using some JS hack to do Turbolinks.visit. Using Turbolinks.visit in itself seems like a really hacky way to do links when we should let the browser handle links as people click links differently (right click new tab, cmd click - whatever the windows version of this is, middle mouse click etc. etc.)

@iamphill I am ok with making it a link. But then you do have to fix any problems that come with that.

Status changed to merged

@jschatz1 im ok with that

Is the only reason we did the JS thing to fix the transition? It still does the animation just doesn't fade?

mentioned in commit bb7af46d

@iamphill I guess that's a good boring solution.

mentioned in issue #18655 (closed)

mentioned in issue #18343 (closed)

mentioned in merge request !4888 (merged)

mentioned in commit 214137aa

mentioned in commit 12af7464

Mentioned in issue #23017 (closed)