Resolve "Graphs and Wiki subnav"
What does this MR do?
Styles sub nav in Wiki and Graphs
What are the relevant issue numbers?
Closes #18533 (closed)
Screenshots (if relevant)
Merge request reports
Activity
Added 38 commits:
- f19a072b...af493ccf - 34 commits from branch
master - 19682c40 - Style sub nav links in Graphs
- 59d6d238 - Style wiki sub nav links
- 4d63a52e - Update CHANGELOG
- 429142bd - Fix graph columns
Toggle commit list- f19a072b...af493ccf - 34 commits from branch
Added 6 commits:
- 429142bd...32a5ff70 - 2 commits from branch
master - e5248586 - Style sub nav links in Graphs
- a5c13935 - Style wiki sub nav links
- 0224ab40 - Update CHANGELOG
- 83ca2b85 - Fix graph columns
Toggle commit list- 429142bd...32a5ff70 - 2 commits from branch
Reassigned to @jschatz1
@annabeldunstone should "New Page" be a button like New Issue, New Snippet, New Merge Request, etc?
@connorshea Since that button is always on the Wiki subnav, I think it should look like the other links. It looked out of place as a big green button
@connorshea no. It's a nav item.
1 .top-area 2 %ul.nav-links 1 .nav-links.sub-nav 2 %ul{ class: (container_class) } 3 3 = nav_link(html_options: {class: params[:id] == 'home' ? 'active' : '' }) do -
@annabeldunstone Is this a
li? This doesn't look like aliin aul... -
@jschatz1 This is the same
nav_linkhelper used all over the app. It creates the following structure:
Reassigned to @annabeldunstone
-
@annabeldunstone This whole thing looks weird
Edited by Jacob Schatz Added 146 commits:
- 83ca2b85...d9812bae - 141 commits from branch
master - f8cc887b - Style sub nav links in Graphs
- ff173ae5 - Style wiki sub nav links
- 4b6e1dee - Update CHANGELOG
- 162d9e68 - Fix graph columns
- 8f28e173 - Add new style for sub header block info
Toggle commit list- 83ca2b85...d9812bae - 141 commits from branch
@annabeldunstone @connorshea new page should not be in navigation
-
@jschatz1 good call; that gray section didn't really look right with the new sub nav styling. I've added a new style for those sections that matches the sub-header areas across the other pages. @dzaporozhets Moved the
New Pagebutton out of the nav and into the wiki home page
-
@annabeldunstone awesome!
Reassigned to @jschatz1
Added 58 commits:
- 1da173e7...1051f0c5 - 51 commits from branch
master - 65f00851 - Style sub nav links in Graphs
- 5fb6ad7d - Style wiki sub nav links
- d5a926ac - Update CHANGELOG
- 5215bd0d - Fix graph columns
- d01422e5 - Add new style for sub header block info
- 3e40e34a - Move new page link out of sub nav
- 04e09f30 - Add new page button to wiki home
Toggle commit list- 1da173e7...1051f0c5 - 51 commits from branch
