Skip to content
Snippets Groups Projects

Add setting that allows admins to choose which Git access protocols are enabled.

Merged Patricio Cano requested to merge allow-disabling-of-git-access-protocol into master

What does this MR do?

It allows admins to disable one of the two protocols for Git access. They can choose to enable just SSH, HTTP or allow both. If one of them is disabled, the clone URL in the project will show only the allowed protocol, and no dropdown to change protocols will be presented.

What are the relevant issue numbers?

Full implementation on GitLab's side for #18601 (closed)

GitLab Shell implementation: gitlab-shell!62 (merged)

GitLab Workhorse implementation: gitlab-workhorse!51 (merged)

Screenshots (if relevant)

Screen_Shot_2016-06-16_at_12.26.19_PM Screen_Shot_2016-06-20_at_4.24.54_PM

/cc @jschatz1 this MR touches the UI. Please review.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @patricio Add documentation please!

  • Reassigned to @patricio

  • Author Contributor

    Wow, I can't believe I missed the CHANGELOG and doc changes. I'll add them right away. Thanks for the review @DouweM!

  • Author Contributor

    I realized I'm also missing an API endpoint for it. The next iteration will have all the missing bits :smiley:

  • Patricio Cano Marked this merge request as a Work In Progress

    Marked this merge request as a Work In Progress

  • Patricio Cano Added 73 commits:

    Added 73 commits:

    • ba9f1fc3...db66312c - 72 commits from branch master
    • 4e4f67fd - Add setting that allows admins to choose which Git access protocols are enabled
  • Author Contributor

    @jschatz1 I'm touching CSS now here, not only the UI. Could you please check that my changes are sane?

  • Author Contributor

    @axil I need to add documentation for this feature. Can you help me find the best place? I already added a small note on the Application Settings API documentation, since it will also be possible to change it from there.

  • Patricio Cano Added 1 commit:

    Added 1 commit:

    • adaf7c05 - Fix CSS
  • Patricio Cano Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Reassigned to @DouweM

  • Author Contributor

    @DouweM can you review the backend code again while @axil and I find the best place for the docs?

  • Patricio Cano Added 1 commit:

    Added 1 commit:

    • 090c9448 - Refactor clone button sanitation to its own method to avoid duplication.
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading