Skip to content

Use memorized tags array when searching tags by name

username-removed-367626 requested to merge 18924-gitlab-ce-tags-page-is-not-working-502-read-timeout into master

What does this MR do?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4423 introduced a sorting dropdown for the tags page. As a side effect, the paginated array used is now of Tag objects instead of tag name Strings, and therefore the name sorting (the default) does:

+       VersionSorter.rsort(tag_names).map { |tag_name| find_tag(tag_name) }

The find_tag method is non-memorized, so it hits the repository for every tag. This MR updates it to use the memorized tags array

Are there points in the code the reviewer needs to double check?

No

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ce/tags is not loading

What are the relevant issue numbers?

Closes #18924 (closed)

Screenshots (if relevant)

On my local machine:

BEFORE

Captura_de_pantalla_2016-06-22_a_las_11.22.26_a.m. Captura_de_pantalla_2016-06-22_a_las_11.22.11_a.m.

AFTER

Captura_de_pantalla_2016-06-22_a_las_11.21.16_a.m. Captura_de_pantalla_2016-06-22_a_las_11.21.27_a.m.

Does this MR meet the acceptance criteria?

Merge request reports