Skip to content
Snippets Groups Projects

Disable the email checking part of the standard Health Check

Merged DJ Mountney requested to merge health-check-disable-email into master

What does this MR do?

In order to fix it we have overwritten the email_configured? method in the health check so that it does not check email status during the standard health check.

Why was this MR needed?

The email check used in the Heath Check doesn't properly make use of enough of the SMTP config options to be able to properly test the STMP connection, and as a result could cause a failure.

What are the relevant issue numbers?

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17742

Does this MR meet the acceptance criteria?

Merge request reports

Pipeline #3585367 passed

Pipeline passed for 4cfb1af0 on health-check-disable-email

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 2 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading