Skip to content

Ace ventura

username-removed-386624 requested to merge ace-ventura into master

What does this MR do?

Makes Ace only load when it's actually necessary. The only two places it seems to be used is for Snippets and the File (Blob) Editor.

Before minification or compression, this takes the application.js down from 2.2MB to 1.6MB, and also removes two inline scripts :D

Compressed/Minified: master: 317KB/1.1MB, ace-ventura: 220KB/771KB

Are there points in the code the reviewer needs to double check?

That this doesn't just completely break anything.

Why was this MR needed?

Ace is a big library, this allows us to only load it when necessary.

What are the relevant issue numbers?

#14372 (closed)

Does this MR meet the acceptance criteria?

Merge request reports