Do not show build retry link when build is active

What does this MR do?

This MR hides a 'Retry' button in build sidebar when build is active.

Are there points in the code the reviewer needs to double check?

Specs for a view used in this MR.

Why was this MR needed?

There was a bug report from customer #19244 (closed).

What are the relevant issue numbers?

Closes #19244 (closed)

Does this MR meet the acceptance criteria?

• CHANGELOG entry added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the style guides
• Branch has no merge conflicts with master (if you do - rebase it please)

mentioned in issue #19244 (closed)

Added 1 commit:

• 53f5cc13 - Improve method that tells if build is retryable

Added 1 commit:

• 78eb8e56 - Add Changelog entry for build sidebar retry link fix

Marked the task CHANGELOG entry added as completed

mentioned in issue #18343 (closed)

Marked the task All builds are passing as completed

Reassigned to @rspeicher

@rspeicher Can you review please? Thanks!

Is there a reason why we add view specific spec? where maybe it would be better to cover that in feature spec: gitlab/spec/features/builds_spec.rb?

This tests view in isolation and this is blazing fast compared to feature specs. We do not need feature specs here.

I agree with @grzesiek. We should be using view specs more often for things like this.

I agree with @grzesiek and @rspeicher

Reassigned to @dbalexandre

@dbalexandre Please review, thanks!

@grzesiek LGTM Can you resolve the MR conflicts?

Reassigned to @grzesiek

@dbalexandre Done, thanks for review! Passing to @rspeicher.

Reassigned to @rspeicher

Added 68 commits:

• 78eb8e56...bef4294c - 65 commits from branch master
• 1bd7d31c - Do not show build retry link when build is active
• cd9b4b58 - Improve method that tells if build is retryable
• ffea9a2e - Add Changelog entry for build sidebar retry link fix

8.9.3 was just tagged, push to 8.9.4 please.

@rspeicher Done! Changelog entry moved to 8.9.4.

Reassigned to @grzesiek

Added 54 commits:

• ffea9a2e...2efee5f6 - 50 commits from branch master
• 94cec500 - Do not show build retry link when build is active
• f9c5f18d - Improve method that tells if build is retryable
• d75787b2 - Add Changelog entry for build sidebar retry link fix
• 8223e280 - Move Changelog entry for build retry fix to 8.9.4

Reassigned to @rspeicher