Skip to content
Snippets Groups Projects

Handle external issues in IssueReferenceFilter

Merged yorickpeterse-staging requested to merge fix-external-issue-rendering into master

What does this MR do?

This MR fixes IssueReferenceFilter so it properly renders issue references such as #1 as external issue links whenever the corresponding project uses an external issue tracker.

Are there points in the code the reviewer needs to double check?

Currently IssueReferenceFilter duplicates a bit of code used to determine the title for a link. I can't really think of a way to share this logic with ExternalIssueReferenceFilter in a way that isn't messy.

Why was this MR needed?

Rendering issue references such as #1 was broken for projects using an external issues tracker.

What are the relevant issue numbers?

gitlab-org/gitlab-ce#19036,

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #19036 (closed)

  • Stan Hu Added 1 commit:

    Added 1 commit:

    • 33bda9c3 - Fix broken spec in git_push_service_spec by stubbing an external issue tracker
  • yorickpeterse-staging Added ~149423 label

    Added ~149423 label

  • Added 2 commits:

    • a4ce2d12 - Handle external issues in IssueReferenceFilter
    • 4fca633a - Fix broken spec in git_push_service_spec by stubbing an external issue tracker
  • Robert Speicher mentioned in commit 6e82c0e0

    mentioned in commit 6e82c0e0

  • Robert Speicher Status changed to merged

    Status changed to merged

  • @yorickpeterse: Wasn't clear if this actually closes #19036 (closed), but feel free to close if it does.

  • mentioned in issue #19355 (closed)

  • Robert Speicher Removed ~149423 label

    Removed ~149423 label

  • Picked into 8-9-stable, will be in 8.9.4.

  • Stan Hu mentioned in issue #19404 (closed)

    mentioned in issue #19404 (closed)

  • Stan Hu mentioned in issue #19416 (closed)

    mentioned in issue #19416 (closed)

  • Robert Speicher mentioned in commit e2692686

    mentioned in commit e2692686

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading