Make error pages responsive
What does this MR do?
This MR makes error pages responsive design and all users have better experiences on 404/422/500/502/503/in-deploy error.
Are there points in the code the reviewer needs to double check?
n/a
Why was this MR needed?
404/422/500/502/503/in-deploy error pages were designed only for PC and not good for mobile users.
What are the relevant issue numbers?
Closes #19345 (closed)
Screenshots (if relevant)
PC
mobile
(with max-width: 40vw
for img
(@connorshea) and max-width: 800px
for hr
(@annabeldunstone) )
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
Merge request reports
Activity
Marked the task Squashed related commits together as completed
Marked the task Conform by the style guides as completed
Marked the task CHANGELOG entry added as completed
Marked the task Documentation created/updated as completed
@jschatz could you review this or assign this to someone else?
Added 393 commits:
- cb6becb0...c66a7b0e - 390 commits from branch
gitlab-org:master
- 4c13bb7f - Make error pages responsive design
- 58e49109 - Unify HTML format in static error pages
- e43074dd - Update CHANGELOG
Toggle commit list- cb6becb0...c66a7b0e - 390 commits from branch
This merge request contains merge conflicts
I made
rebase master
. /cc @jschatzAdded 15 commits:
- e43074dd...3c89a788 - 12 commits from branch
gitlab-org:master
- 565735fb - Make error pages responsive design
- f1c04dac - Unify HTML format in static error pages
- 0b610e41 - Update CHANGELOG
Toggle commit list- e43074dd...3c89a788 - 12 commits from branch
This merge request contains merge conflicts
I made
rebase master
. /cc @jschatzAdded 473 commits:
-
43cf137b...2556d6d3 - 470 commits from branch
gitlab-org:master
- dcf041bf - Make error pages responsive design
- c60b3e94 - Unify HTML format in static error pages
- ee9ae3bd - Update CHANGELOG
Toggle commit list-
43cf137b...2556d6d3 - 470 commits from branch
mentioned in issue #19345 (closed)
Added frontend label
Reassigned to @connorshea
@tnir Can you add this to the style?:
img { max-width: 40vw; }
That way the tanuki logo isn't awkwardly large on smaller devices. Other than that, this looks good to me
Update it (and rebase on master, if you can), ping me, and I'll assign to someone so they can merge. Sorry that no one reviewed this sooner, jschatz has been really busy lately.