Skip to content
Snippets Groups Projects

Send ajax request for label update only if they are changed

Merged Send ajax request for label update only if they are changed
label-update-check-new into master
1 unresolved thread
Merged Phil Hughes requested to merge label-update-check-new into master
1 unresolved thread

What does this MR do?

At the moment we send requests to update the labels on issue even if nothing has been changed. This fixes that and only sends requests when something has actually been changed.

The code gets the initial selected values based on the inputs & then compares that to the selected values when submitting. If they are equal, then no request is sent.

What are the relevant issue numbers?

Closes #19472 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
app/assets/javascripts/labels_select.js
24 24 $sidebarLabelTooltip = $block.find('.js-sidebar-labels-tooltip');
25 25 $value = $block.find('.value');
26 26 $loading = $block.find('.block-loading').fadeOut();
27 initialSelected = $dropdown.closest('.selectbox')
  • Jacob Schatz
  • Phil Hughes Added 1 commit:

    Added 1 commit:

  • Phil Hughes Added 1 commit:

    Added 1 commit:

  • Phil Hughes Added 282 commits:

    Added 282 commits:

  • Jacob Schatz
    Jacob Schatz @jschatz1 ·
    Maintainer

    Conflicts. @iamphill

  • Jacob Schatz Reassigned to @iamphill

    Reassigned to @iamphill

  • Phil Hughes Added 536 commits:

    Added 536 commits:

  • Phil Hughes Reassigned to @jschatz1

    Reassigned to @jschatz1

  • Jacob Schatz Added ~149423 label

    Added ~149423 label

  • Jacob Schatz Removed ~149423 label

    Removed ~149423 label

  • Jacob Schatz Added ~149423 label

    Added ~149423 label

  • Jacob Schatz
    Jacob Schatz @jschatz1 ·
    Maintainer

    Testing the labels. Worked.

  • Jacob Schatz
    Jacob Schatz @jschatz1 ·
    Maintainer

    @iamphill conflicts again. Sorry buddy.

  • Jacob Schatz
    Jacob Schatz @jschatz1 ·
    Maintainer

    @mikegreiling can you fix the conflicts here since @iamphill is out?

  • Jacob Schatz Reassigned to @mikegreiling

    Reassigned to @mikegreiling

  • username-removed-636429 Added 263 commits:

    Added 263 commits:

  • Phil Hughes Mentioned in commit d34d4f7f

    Mentioned in commit d34d4f7f

  • username-removed-636429 Added 1 commit:

    Added 1 commit:

  • Phil Hughes Mentioned in commit b13213e6

    Mentioned in commit b13213e6

  • username-removed-636429 Added 1 commit:

    Added 1 commit:

  • username-removed-636429
    username-removed-636429 @mikegreiling ·
    Maintainer

    I've squashed everything into one commit, and tested it out locally. Should be good to go :ok_hand:

    I would, however, add that I think this issue should also be tackled in the backend. Whether we prevent the superfluous ajax call on the frontend or not, the fact that the backend triggers notifications and web hooks when nothing has changed is a problem that should be fixed.

  • username-removed-636429 Reassigned to @jschatz1

    Reassigned to @jschatz1

  • username-removed-636429 Mentioned in issue #22697 (moved)

    Mentioned in issue #22697 (moved)

  • Jacob Schatz Status changed to merged

    Status changed to merged

  • Jacob Schatz Mentioned in commit 4d4506ad

    Mentioned in commit 4d4506ad

  • Rubén Dávila Mentioned in issue #22556 (closed)

    Mentioned in issue #22556 (closed)

  • Rubén Dávila
    Rubén Dávila @rdavila ·
    Maintainer

    Picked into 8-12-stable, will go into 8.12.2.

  • Rubén Dávila Removed ~149423 label

    Removed ~149423 label

  • Jacob Schatz Mentioned in commit 71472bde

    Mentioned in commit 71472bde

  • Felipe Artur mentioned in issue gitlab#6406

    mentioned in issue gitlab#6406

    • Please register or sign in to reply