Update container_registry.md
What does this MR do?
Add a warning about what ports to choose for the external registry URL
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
It would have saved me about 3 hours if this line was in the document.
What are the relevant issue numbers?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
It's just a one-line documentation addition.
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
Merge request reports
Activity
Marked the task CHANGELOG entry added as completed
Marked the task Documentation created/updated as completed
Marked the task Conform by the style guides as completed
Marked the task Squashed related commits together as completed
Reassigned to @axil
122 122 in `gitlab.rb` or `gitlab.yml` if you are using Omnibus GitLab or installed 123 123 GitLab from source respectively. 124 124 125 N.B. Do not choose port 5000, it will conflict with the Docker registry service. Yes, i think so. It's the api_url parameter that controls what port the registry listens on, right? So I suppose as long as those two are different then you're safe.
Added 1 commit:
- 9f6ceed5 - Update container_registry.md
@axil what do you think now?
Milestone changed to %8.11
Added ~15078 container registry labels
mentioned in commit 2e8a9650
@dwarburt awesome! Thanks for spotting this in the first place, edge cases should always be documented.
Mentioned in commit tnir/gitlab-ce@2e8a9650