Update to gitlab_git 10.4.1 and take advantage of preserved Ref objects
Merged
requested to merge 17073-tagscontroller-index-is-terrible-response-time-goes-up-to-5-seconds into master
Do not update/delete: Banner broadcast message test data
Do not update/delete: Notification broadcast message test data
This is the fixed version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5375, that got reverted because I missed some of the code that needed refactoring. I added specs and examples for all the code that failed on the last MR but wasn't covered by the existing specs.
Yes. The gitlab_git update changed the interface of the Gitlab::Git::Tag and Gitla::Git::Branch objects so that their target is a Gitlab::Git::Commit instead of a sha string. All the code that was expecting a sha string must be changed to account for this
The TagsController performance is suboptimal
Closes #17073 (closed)
master (if you do - rebase it please)