Skip to content

use with_indifferent_access on params

username-removed-28993 requested to merge bugfix/service-params-indifferent-access into master

What does this MR do?

Protects service params that have been through sidekiq from being missed due to automatic stringification of keys

Are there points in the code the reviewer needs to double check?

The previous implementation uses dup. A similar shallow copy is already implied by with_indifferent_access.

Why was this MR needed?

The :skip_repo option in Projects::DestroyService was being missed when run asynchronously.

Does this MR meet the acceptance criteria?

Merge request reports