Skip to content

Load branch dropdowns asynchronously for cherry pick and revert dialogs

username-removed-386624 requested to merge cs-async-branch-dropdown into master

Why was this MR needed and what does it do?

Previously every commit page was loading every branch onto the page twice, once each for the Cherry Pick and Revert modal dialogs. Most of the time they're never used, so that's a bit of a waste.

This loads them asynchronously by modifying the existing ref switcher code to also work for the branch selectors. This is better for performance.

Are there points in the code the reviewer needs to double check?

Make sure Cherry Picking and Reverting still work (from my tests they seem to be fine).

What are the relevant issue numbers?

Fixes #20108 (closed).

Screenshots (if relevant)

Before:

Screen_Shot_2016-08-01_at_4.35.21_PM

Screen_Shot_2016-08-01_at_4.35.52_PM

After:

Screen_Shot_2016-08-01_at_4.32.49_PM

Screen_Shot_2016-08-01_at_4.32.56_PM

Screen_Shot_2016-08-01_at_4.33.02_PM

Does this MR meet the acceptance criteria?

cc: @iamphill @jschatz1

Merge request reports