Skip to content

Add todo toggle event

username-removed-408677 requested to merge ClemMakesApps/gitlab-ce:add-todo-toggle-event into master

What does this MR do?

Adds a custom jQuery event todo:toggle to detect when a new todo is added so that the respective todo counters (header navigation and sidebar) can update as needed

Are there points in the code the reviewer needs to double check?

  • I wasn't sure whether each spec should be modularized based on the html templates or whether they should be separated based on function. There are some crossovers between the dashboard_spec and the header_spec.
  • The naming conventions for sidebar and right_sidebar were a little confusing since they were named the opposite in their specs. I made a few assumptions and named a few files based on what I thought they should be named. I'd be happy to change it to something else though 😄

Why was this MR needed?

This resolves an existing issue where the todo count on the sidebar would not update (until refresh) and refactors the existing methods that are used to update the todo counters (header navigation and sidebar)

What are the relevant issue numbers?

Closes #20140 (closed)

Does this MR meet the acceptance criteria?

Merge request reports