Skip to content

Client-Side Terminal Emulation with Line Numbers

username-removed-441905 requested to merge deckar01/gitlab-ce:xterm-display into master

What does this MR do?

  • Converts ansi to HTML client side using xterm-display
  • Adds line numbers anchors 🍰

Are there points in the code the reviewer needs to double check?

  • AsyncTerminal chunkSize option (it offers the ability to tradeoff between write speed and DOM jank)
  • Build and build trace unit tests

Why was this MR needed?

git emits ANSI escape codes to clear the line, but the GitLab CI ignores them.

The only possibility to fix this is to move ANSI terminal emulation to client side.

#14724 (moved)

What are the relevant issue numbers?

Screenshots (if relevant)

gitlab_term_2

Does this MR meet the acceptance criteria?

Merge request reports