Add test requirement for new files (!5813) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged username-removed-444 requested to merge dz-test-required into master 8 years ago

1 unresolved thread

Activity

Robert Speicher @rspeicher · 8 years ago

Owner

Should we say "every new class should have corresponding unit tests, even if the class is exercised at a higher level, such as a feature test."?
username-removed-443319 @smcgivern started a thread on an old version of the diff 8 years ago

CONTRIBUTING.md

 . The change is as small as possible
 . Include proper tests and make all tests pass (unless it contains a test
    exposing a bug in existing code)
    exposing a bug in existing code). Every new file with code you created
    must have a corresponging file with tests even if functionality is

Robert Speicher Reassigned to @dzaporozhets 8 years ago

Reassigned to @dzaporozhets

username-removed-444 @dzaporozhets · 8 years ago

Author Owner

@rspeicher yep I will update with your proposal

username-removed-444 Added 1 commit: 8 years ago

Added 1 commit:

b99f8411 - Update contribution acceptance criteria with tests requirements

username-removed-444 Reassigned to @rspeicher 8 years ago

Reassigned to @rspeicher

username-removed-444 Added 1 commit: 8 years ago

Added 1 commit:

b99f8411 - Update contribution acceptance criteria with tests requirements

Robert Speicher mentioned in commit 8 years ago

mentioned in commit 302caf59

Robert Speicher Status changed to merged 8 years ago

Status changed to merged

Please register or sign in to reply