Skip to content

Removed sleep calls introduced in !5740

Luke "Jared" Bennett requested to merge remove-sleep-calls-from-phantom-update-spinach-specs into master

What does this MR do?

Removes sleep calls introduced in !5740 (merged).

Are there points in the code the reviewer needs to double check?

Before this can pass we need a method similar to the wait_for_ajax that our Capybara tests use.

We also need a revised method for Capybara anyway as vuejs doesn't use jQuery for AJAX requests making the wait_for_ajax method useless.

@alfredo1 suggested writing middleware to count and expose the total XMLHttpRequests fired from vue-resource. Maybe this can be contributed upstream?

/cc @connorshea @iamphill @rspeicher @jschatz1

Why was this MR needed?

What are the relevant issue numbers?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

Merge request reports