Skip to content

Reduce notification setting change payload

What does this MR do?

Instead of directly updating the DOM with the notifications settings change payload, this MR uses jQuery to perform the UI changes after the payload is received.

Are there points in the code the reviewer needs to double check?

Shouldn't be

Why was this MR needed?

  • Improves existing UI
  • Reduces the bandwidth usage (4.3kb to 479b) 🎈

What are the relevant issue numbers?

Closes #20979 (moved)
Closes #20980 (moved)

Screenshots (if relevant)

Before: 0CiVH5mOya__1_

After: GSknjuVtel

Before (Payload): Screen_Shot_2016-08-16_at_4.16.47_PM Screen_Shot_2016-08-16_at_4.17.17_PM

After (Payload): Screen_Shot_2016-08-16_at_4.15.01_PM Screen_Shot_2016-08-16_at_4.16.23_PM

Does this MR meet the acceptance criteria?

Merge request reports