Skip to content

WIP: Make event names more consistent

username-removed-423915 requested to merge no-special-names-for-fields into master

What does this MR do?

This is a follow up from !5620 (merged) where we want to use consistent names in the view.

Are there points in the code the reviewer needs to double check?

Actually this is half done without renaming columns, unfortunately. Given the fact that this is where the inconsistency introduced:

scope :issue_hooks, -> { where(issues_events: true, active: true) }
scope :merge_request_hooks, -> { where(merge_requests_events: true, active: true) }

Note that on the left it's singular and on the right it's plural, and all the other events are all consistently using singular.

Should we also rename them?

/cc @rspeicher

Merge request reports